Fix IN Clause Formatting #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes IN clause formatting issues by implementing dedicated handling for conditional directives in SQL formatting, ensuring that test data in IN clauses maintains proper formatting without unwanted line breaks.
- Introduced a dedicated
SqlInGroupBlockto explicitly handle IN clause formatting - Added a method to determine conditional directive positioning relative to parent blocks
- Updated parent-child relationship logic for conditional directives to ensure proper formatting control
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
SqlFormatterTest.kt |
Added new test methods for conditional clause formatting scenarios |
SqlBlockGenerator.kt |
Added generation logic for IN group blocks and WHERE group blocks |
NotQueryGroupHandler.kt |
Updated IN keyword detection and function/alias context handling |
SqlBlockRelationBuilder.kt |
Enhanced parent-child relationship handling for conditional directives |
SqlInGroupBlock.kt |
New dedicated block class for handling IN clause formatting |
SqlWhereGroupBlock.kt |
New WHERE group block implementation |
| Various test data files | Test cases demonstrating proper conditional directive formatting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...tlin/org/domaframework/doma/intellij/formatter/block/group/keyword/option/SqlInGroupBlock.kt
Outdated
Show resolved
Hide resolved
...tlin/org/domaframework/doma/intellij/formatter/block/group/keyword/option/SqlInGroupBlock.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where test data used inside an IN clause was unintentionally broken into multiple lines during SQL formatting.
Relation
#397
Details
Impact